[SDL] 'repeat' flag on SDL_KeyboardEvent not being set on 2.0.5

Discussion:

Daniel Ribeiro Maciel

2016-10-24 23:12:45 UTC

Hi guys,

I've recently upgraded from 2.0.4 to 2.0.5 and noticed the 'repeat' flag on
SDL_KeyboardEvent is not being set properly anymore on my system.

I'm using Ubuntu 16.04, with the X11 backend (XLIB).

I've tried to create a bug report on bugzilla but I couldn't set the
version to 2.0.5 there.

Best regards,
Daniel

Alex Baines

2016-10-25 01:06:02 UTC

Permalink

Hmm, some patches I wrote that made it into 2.0.5 related to x11
keyboard code, so this may be my fault.

I tried to reproduce the behaviour locally using the checkkeys test, but
that shows key repeats correctly.

Maybe using 'hg bisect' with checkkeys could help you locate the commit
that introduced this.

Alex.

Post by Daniel Ribeiro Maciel
Hi guys,
I've recently upgraded from 2.0.4 to 2.0.5 and noticed the 'repeat' flag on
SDL_KeyboardEvent is not being set properly anymore on my system.
I'm using Ubuntu 16.04, with the X11 backend (XLIB).
I've tried to create a bug report on bugzilla but I couldn't set the
version to 2.0.5 there.
Best regards,
Daniel
_______________________________________________
SDL mailing list
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Daniel Ribeiro Maciel

2016-10-25 02:05:26 UTC

Permalink

Found the culprit:

changeset: 10500:c3874aa1f2d1
user: Sam Lantinga <***@libsdl.org>
date: Sat Oct 08 11:30:07 2016 -0700
summary: Fixed building and using fcitx IME support on Linux

Trying to figure out what is wrong with it.

Post by Alex Baines
Hmm, some patches I wrote that made it into 2.0.5 related to x11
keyboard code, so this may be my fault.
I tried to reproduce the behaviour locally using the checkkeys test, but
that shows key repeats correctly.
Maybe using 'hg bisect' with checkkeys could help you locate the commit
that introduced this.
Alex.

Post by Daniel Ribeiro Maciel
Hi guys,
I've recently upgraded from 2.0.4 to 2.0.5 and noticed the 'repeat' flag

Post by Daniel Ribeiro Maciel
SDL_KeyboardEvent is not being set properly anymore on my system.
I'm using Ubuntu 16.04, with the X11 backend (XLIB).
I've tried to create a bug report on bugzilla but I couldn't set the
version to 2.0.5 there.
Best regards,
Daniel
_______________________________________________
SDL mailing list
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

_______________________________________________
SDL mailing list
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Daniel Ribeiro Maciel

2016-10-25 02:33:16 UTC

Permalink

Apparently the problem is that now I'm forced to have either
HAVE_IBUS_IBUS_H or HAVE_FCITX_FRONTEND_H defined.

I think SDL now expects ibus headers installed (or fcitx dev) otherwise
new_xmods will not be set to "@im=none" which is the cause of the problem.

I'm forcing has_dbus_ime_support to SDL_TRUE and everthing works as
expected.

If I install libibus-dev everything works as expected but I see no reason
to require ibus headers if they are not really required in this case?

On Tue, Oct 25, 2016 at 12:05 AM, Daniel Ribeiro Maciel <

Post by Daniel Ribeiro Maciel
changeset: 10500:c3874aa1f2d1
date: Sat Oct 08 11:30:07 2016 -0700
summary: Fixed building and using fcitx IME support on Linux
Trying to figure out what is wrong with it.

Post by Daniel Ribeiro Maciel
Hi guys,
I've recently upgraded from 2.0.4 to 2.0.5 and noticed the 'repeat'

flag on

_______________________________________________
SDL mailing list
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Daniel Ribeiro Maciel

2016-10-25 02:35:40 UTC

Permalink

I have added libibus-1.0-dev to my bootstrap script here. Thanks for the
help Alex.

Best regards,
Daniel

On Tue, Oct 25, 2016 at 12:33 AM, Daniel Ribeiro Maciel <

Post by Daniel Ribeiro Maciel
Apparently the problem is that now I'm forced to have either
HAVE_IBUS_IBUS_H or HAVE_FCITX_FRONTEND_H defined.
I think SDL now expects ibus headers installed (or fcitx dev) otherwise
I'm forcing has_dbus_ime_support to SDL_TRUE and everthing works as
expected.
If I install libibus-dev everything works as expected but I see no reason
to require ibus headers if they are not really required in this case?
On Tue, Oct 25, 2016 at 12:05 AM, Daniel Ribeiro Maciel <

Post by Daniel Ribeiro Maciel
Hi guys,
I've recently upgraded from 2.0.4 to 2.0.5 and noticed the 'repeat'

flag on

_______________________________________________
SDL mailing list
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Ryan C. Gordon

2016-10-25 04:05:36 UTC

Permalink

Post by Daniel Ribeiro Maciel
If I install libibus-dev everything works as expected but I see no
reason to require ibus headers if they are not really required in this case?

This is probably an unintentional bug. I've added a "2.0.5" version to
Bugzilla; if you get a moment, please file a bug and we'll look into this!

Thanks,
--ryan.

sezero

2016-10-27 09:10:34 UTC

Permalink

This is possibly related to https://bugzilla.libsdl.org/show_bug.cgi?id=3472

Daniel Ribeiro Maciel

2016-10-27 15:10:58 UTC

Permalink

Yes, I got key repeated key up and down events. It is the same bug.

Post by sezero
This is possibly related to https://bugzilla.libsdl.org/
show_bug.cgi?id=3472
_______________________________________________
SDL mailing list
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org